-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags from dbt_project.yml to the Project and RuntimeConfig objects #10644
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10644 +/- ##
==========================================
+ Coverage 88.86% 88.91% +0.04%
==========================================
Files 180 180
Lines 22762 22799 +37
==========================================
+ Hits 20228 20272 +44
+ Misses 2534 2527 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10644-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1d3d315249c81dbca70452e5a14fbfd0edad6b2a
# Push it to GitHub
git push --set-upstream origin backport-10644-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
…nd RuntimeConfig objects (#10723) * backport #10644 --------- Co-authored-by: Michelle Ark <[email protected]>
Resolves #10618
Problem
We need to pass project flags from
dbt_project.yml
into theBaseAdapter
instantiation to support behavior flags. Without this, users cannot override a behavior flag.Solution
flags
as an attribute onProject
, which then adds it toRuntimeConfig
dbt_project.yml::flags
, not the global flagsRuntimeConfig
contains arbitrary flags added indbt_project.yml::flags
Checklist