Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIDY FIRST] Fix core/dbt/version.py type hinting #10613

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

QMalcolm
Copy link
Contributor

Resolves #10612

Problem

There were type errors in core/dbt/version.py

Solution

Fix the type errors

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

* Added type hints to `_get_core_msg_lines` parameters
* Removed unused `# type: ignore` comment
@QMalcolm QMalcolm added the tidy_first "Tidy First" incremental cleanup changes label Aug 27, 2024
@QMalcolm QMalcolm requested a review from a team as a code owner August 27, 2024 15:52
@cla-bot cla-bot bot added the cla:yes label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (f25a474) to head (552c7c9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10613      +/-   ##
==========================================
- Coverage   88.91%   88.86%   -0.05%     
==========================================
  Files         180      180              
  Lines       22760    22760              
==========================================
- Hits        20237    20226      -11     
- Misses       2523     2534      +11     
Flag Coverage Δ
integration 86.10% <100.00%> (-0.12%) ⬇️
unit 62.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.33% <100.00%> (ø)
Integration Tests 86.10% <100.00%> (-0.12%) ⬇️

@QMalcolm QMalcolm merged commit 09f9feb into main Aug 27, 2024
77 of 78 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--10612-fix-core-dbt-version-type-hinting branch August 27, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing type hints to dbt/core/version.py
2 participants