Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated saved query tests and fixtures #10610

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

WilliamDee
Copy link
Contributor

Problem

Updating the saved query tests and fixtures to be correct

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@WilliamDee WilliamDee added the Skip Changelog Skips GHA to check for changelog file label Aug 26, 2024
@WilliamDee WilliamDee requested a review from a team as a code owner August 26, 2024 20:43
@cla-bot cla-bot bot added the cla:yes label Aug 26, 2024
@github-actions github-actions bot added the community This PR is from a community member label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (3c55806) to head (1cba66f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10610      +/-   ##
==========================================
- Coverage   88.92%   88.86%   -0.07%     
==========================================
  Files         180      180              
  Lines       22760    22760              
==========================================
- Hits        20240    20226      -14     
- Misses       2520     2534      +14     
Flag Coverage Δ
integration 86.10% <ø> (-0.14%) ⬇️
unit 62.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.33% <ø> (ø)
Integration Tests 86.10% <ø> (-0.14%) ⬇️

@gshank gshank merged commit f25a474 into main Aug 26, 2024
68 of 69 checks passed
@gshank gshank deleted the will/update-saved-query-tests branch August 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants