-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve relative local dependencies of local dependencies #10600
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10600 +/- ##
==========================================
- Coverage 88.91% 86.72% -2.20%
==========================================
Files 180 180
Lines 22755 22766 +11
==========================================
- Hits 20232 19743 -489
- Misses 2523 3023 +500
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…n type "Dict[str, Optional[str]]" in supertype "PinnedPackage"
…ict[str, Optional[str]]")
Failing two tests related to ensuring partial parsing still works after renaming the root directory of a dbt project:
Source code: |
Resolves #5410
Problem
#5410 describes how package dependencies that include transitive relative paths to a parent directory don't work as expected. e.g., when
packages.yml
has a local package and that package also depends on a different local package, the paths get messed up.This is because currently, the local package's resolved path is always relative to the root project from which
dbt deps
is run.Solution
Per #5410 (comment), find a way to pass in the absolute path of the package's
packages.yml
.E.g., get the location of the
packages.yml
file in which each local package specification is actually defined. Then pass in the absolute path of that location and use it to resolve the local package's path.Checklist