Fixes dbt retry does not respect --threads #10591
Open
+75
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10591 +/- ##
==========================================
- Coverage 88.91% 88.86% -0.05%
==========================================
Files 180 180
Lines 22755 22755
==========================================
- Hits 20232 20222 -10
- Misses 2523 2533 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ChenyuLInx
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks @donjin-master for adding this patch!
LGTM in general, one small question about the tests
|
|
||
| assert {n.node.name: n.status for n in results.results} == expected_statuses | ||
| assert results.args["threads"] == 1 | ||
| write_file(models__thread_model, "models", "thread_model.sql") |
There was a problem hiding this comment.
Is this and the write_file above needed?
graciegoheen
added
the
ready_for_review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10584
Problem
Solving the problem when retry has been run. dbt does not respect a new --threads value when passed in on a retry.
Solution
Added the threads in ALLOW_CLI_OVERRIDE_FLAGS to fetch the thread value
Checklist