Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DSI version #10585

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Bump DSI version #10585

merged 2 commits into from
Aug 20, 2024

Conversation

courtneyholcomb
Copy link
Contributor

Description

Bump DSI version. This is needed to enable development in MetricFlow against new DSI versions. Note that there are no breaking changes in the DSI jump to 0.7.0. There are only a couple small added features which will need to be added to the core parser before they impact users, so this PR will not impact core at all.
For context, the reason this blocks development in MF is that we rely on core adapters in MF tests. So if we upgrade to a version of DSI in MF that's incompatible with core, we're unable to run tests.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@courtneyholcomb courtneyholcomb added the Skip Changelog Skips GHA to check for changelog file label Aug 20, 2024
@courtneyholcomb courtneyholcomb requested a review from a team as a code owner August 20, 2024 02:05
@cla-bot cla-bot bot added the cla:yes label Aug 20, 2024
@github-actions github-actions bot added the community This PR is from a community member label Aug 20, 2024
@courtneyholcomb courtneyholcomb added the semantic Issues related to the semantic layer label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (3695698) to head (ca9ad3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10585   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         180      180           
  Lines       22755    22755           
=======================================
  Hits        20228    20228           
  Misses       2527     2527           
Flag Coverage Δ
integration 86.13% <ø> (ø)
unit 62.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.34% <ø> (ø)
Integration Tests 86.13% <ø> (ø)

@peterallenwebb peterallenwebb merged commit 84eb0ff into main Aug 20, 2024
66 checks passed
@peterallenwebb peterallenwebb deleted the court/bump branch August 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member semantic Issues related to the semantic layer Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants