Fix add_ephemeral_prefix to identifier instead of name

[aranke]

Problem

Functional tests for "dbt unit testing" are failing on database errors like so:

  An error occurred during execution of unit test 'test_my_model_version_ref'. There may be an error in the unit test definition: check the data types.
   Database Error
    relation "__dbt__cte__my_model_v2" does not exist
    LINE 21: ) select * from __dbt__cte__my_model_v2

This is related to this PR merged yesterday: dbt-labs/dbt-adapters#236

Solution

Pass in cte_model.identifier instead of cte_model.name to add_ephemeral_prefix.

Checklist

• I have read the contributing guide and understand what's expected of me.
• I have run this code in development, and it appears to resolve the stated issue.
• This PR includes tests, or tests are not required or relevant for this PR.
• This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
• This PR includes type annotations for new and modified functions.

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (3d09872) to head (83ce993).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10550      +/-   ##
==========================================
- Coverage   88.90%   88.87%   -0.04%     
==========================================
  Files         180      180              
  Lines       22721    22721              
==========================================
- Hits        20200    20193       -7     
- Misses       2521     2528       +7     

Flag	Coverage Δ
integration	86.10% <100.00%> (-0.04%)	⬇️
unit	62.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Unit Tests	62.35% <0.00%> (ø)
Integration Tests	86.10% <100.00%> (-0.04%)	⬇️

[MichelleArk]

🎯

[ChenyuLInx]

Ops, Community contribution with test here

[MichelleArk]

nicely done!