Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 10534 to 1.8.latest #10541

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Aug 7, 2024

Manual backport of #10534 to 1.8

@cla-bot cla-bot bot added the cla:yes label Aug 7, 2024
@MichelleArk MichelleArk changed the base branch from main to 1.8.latest August 7, 2024 15:58
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (4f50172) to head (a56ffd1).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #10541      +/-   ##
==============================================
- Coverage       88.32%   88.26%   -0.06%     
==============================================
  Files             181      181              
  Lines           22776    22779       +3     
==============================================
- Hits            20116    20106      -10     
- Misses           2660     2673      +13     
Flag Coverage Δ
integration 85.44% <100.00%> (-0.15%) ⬇️
unit 62.81% <92.85%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk merged commit 60315b6 into 1.8.latest Aug 7, 2024
67 checks passed
@MichelleArk MichelleArk deleted the backport-10534-to-1.8.latest branch August 7, 2024 16:38
Copy link
Contributor

github-actions bot commented Aug 7, 2024

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-10541-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 60315b6a750c2065db342ec26ba8c1696325f7e6
# Push it to GitHub
git push --set-upstream origin backport-10541-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-10541-to-1.7.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants