-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-364] Add group
info to RunResultError
, RunResultFailure
, RunResultWarning
log lines
#10535
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10535 +/- ##
==========================================
- Coverage 88.93% 88.84% -0.10%
==========================================
Files 180 180
Lines 22735 22755 +20
==========================================
- Hits 20220 20217 -3
- Misses 2515 2538 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
group
info to RunResultError
, RunResultFailure
, RunResultError
log line
group
info to RunResultError
, RunResultFailure
, RunResultError
log linegroup
info to RunResultError
, RunResultFailure
, RunResultError
log lines
group
info to RunResultError
, RunResultFailure
, RunResultError
log linesgroup
info to RunResultError
, RunResultFailure
, RunResultError
log lines
group
info to RunResultError
, RunResultFailure
, RunResultError
log linesgroup
info to RunResultError
, RunResultFailure
, RunResultWarning
log lines
@@ -144,9 +157,11 @@ def print_run_end_messages(results, keyboard_interrupt: bool = False) -> None: | |||
) | |||
|
|||
for error in errors: | |||
print_run_result_error(error, is_warning=False) | |||
group = groups.get(error.node.unique_id) if groups and hasattr(error, "node") else None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, iiuc this is printing the summary of all model errors with the group info for those models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these summary logs have a different code (like how individual model failures have "Z002")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes:
RunResultWarning
– Z021RunResultFailure
– Z022RunResultError
– Z024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, but I'd simplify the protobuf Group a bit.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-10535-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3695698e220843a1c41d9184c6fb4cbbf52eb1fc
# Push it to GitHub
git push --set-upstream origin backport-10535-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10535-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3695698e220843a1c41d9184c6fb4cbbf52eb1fc
# Push it to GitHub
git push --set-upstream origin backport-10535-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
Resolves https://dbtlabs.atlassian.net/browse/CORE-364
Problem
We need to add group info to
RunResultError
,RunResultFailure
,RunResultWarning
log lines for alerting.Solution
Group
proto message.RunResultError
,RunResultFailure
,RunResultWarning
.Checklist