Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state:modified.vars #10502

Closed
wants to merge 11 commits into from
Closed

state:modified.vars #10502

wants to merge 11 commits into from

Conversation

MichelleArk
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jul 29, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 92.64706% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (5e3d418) to head (a146642).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10502      +/-   ##
==========================================
- Coverage   89.16%   84.82%   -4.35%     
==========================================
  Files         183      183              
  Lines       23258    23374     +116     
==========================================
- Hits        20738    19827     -911     
- Misses       2520     3547    +1027     
Flag Coverage Δ
integration 84.82% <92.64%> (-1.64%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 84.82% <92.64%> (-4.35%) ⬇️
Integration Tests 84.82% <92.64%> (-1.64%) ⬇️

@MichelleArk MichelleArk added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Jul 29, 2024
@MichelleArk MichelleArk changed the title add state:modified.vars and depends_on.vars state:modified.vars Jul 30, 2024
@MichelleArk
Copy link
Contributor Author

Closing in favor of: #10793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant