Remove newlines from JSON schema files #10486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #10455
Problem
The Artifact Schema Check in CI has been consistently failing due to a conflict between the schema generator and the pre-commit hook
end-of-file-fixer
. The hook adds newlines to the end of JSON files, but the schema generator expects no newlines. When the results are compared, we see a diff, resulting in a CI error.Solution
Remove newlines from JSON schema files and exclude them from the files modified by
end-of-file-fixer
.Checklist