add predicate to EventCatcher test util #10482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # N/A
Problem
The
EventCatcher
module is great for catching specific event types and ensuring they were fired during execution. However, if you want to ensure that specific instantiations of that event type were fired, the mechanism is not flexible enoughSolution
Add an optional
predicate
field toEventCatcher
. It should be a callable that accepts anEventMsg
and returns a boolean so we can do more flexible event catching (e.g.predicate=lambda event: event.data.something == "something!"
)Checklist