Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy First] Update PR template punctuation #10479

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

aranke
Copy link
Member

@aranke aranke commented Jul 23, 2024

My language linter pops up several grammar suggestions every time I create a PR.

The goal of this PR is to fix those suggestions, so I don't see them again.

@aranke aranke requested a review from a team as a code owner July 23, 2024 17:52
@cla-bot cla-bot bot added the cla:yes label Jul 23, 2024
@aranke aranke changed the title [Tidy-First] Update PR template punctuation [Tidy First] Update PR template punctuation Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (229c537) to head (c11052b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10479      +/-   ##
==========================================
- Coverage   88.85%   88.79%   -0.07%     
==========================================
  Files         180      180              
  Lines       22573    22573              
==========================================
- Hits        20058    20043      -15     
- Misses       2515     2530      +15     
Flag Coverage Δ
integration 86.00% <ø> (-0.14%) ⬇️
unit 62.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.22% <ø> (ø)
Integration Tests 86.00% <ø> (-0.14%) ⬇️

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aranke aranke merged commit 560d151 into main Jul 23, 2024
66 of 67 checks passed
@aranke aranke deleted the pr_template_punctuation branch July 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants