Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump black in dev-requirements and pre-commit-config #10407

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 4, 2024

resolves #10454

Problem

#10358 bumped black down so it matched across pre-commit and dev-requirements. let's bump it and keep the matching!

Solution

bump black + apply linting upgrades

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (4c7d922) to head (66d1030).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10407      +/-   ##
==========================================
+ Coverage   88.76%   88.79%   +0.02%     
==========================================
  Files         180      180              
  Lines       22564    22557       -7     
==========================================
  Hits        20029    20029              
+ Misses       2535     2528       -7     
Flag Coverage Δ
integration 86.06% <100.00%> (+0.02%) ⬆️
unit 62.12% <77.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.12% <77.77%> (+0.01%) ⬆️
Integration Tests 86.06% <100.00%> (+0.02%) ⬆️

@MichelleArk MichelleArk added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Jul 4, 2024
@MichelleArk MichelleArk changed the base branch from main to court/default_granularity July 16, 2024 15:18
Base automatically changed from court/default_granularity to main July 16, 2024 17:35
@MichelleArk MichelleArk marked this pull request as ready for review July 17, 2024 14:36
@MichelleArk MichelleArk requested a review from a team as a code owner July 17, 2024 14:36
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MichelleArk MichelleArk merged commit bef2d20 into main Jul 17, 2024
68 checks passed
@MichelleArk MichelleArk deleted the bump-black branch July 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump black version
2 participants