Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak project-test-config deprecation test for misc deprecations #10391

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jul 1, 2024

resolves #10389

Problem

Test sometimes fails because of random other deprecations in global active deprecations variable

Solution

Check that the config is not in set instead of equal to empty set

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label Jul 1, 2024
@gshank gshank requested a review from a team as a code owner July 1, 2024 18:07
@cla-bot cla-bot bot added the cla:yes label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (c215697) to head (475148e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10391      +/-   ##
==========================================
- Coverage   88.81%   88.75%   -0.06%     
==========================================
  Files         180      180              
  Lines       22496    22496              
==========================================
- Hits        19980    19967      -13     
- Misses       2516     2529      +13     
Flag Coverage Δ
integration 86.01% <ø> (-0.15%) ⬇️
unit 62.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.15% <ø> (ø)
Integration Tests 86.01% <ø> (-0.15%) ⬇️

@gshank gshank merged commit b59c907 into main Jul 1, 2024
68 of 69 checks passed
@gshank gshank deleted the fix_tests_config_deprection_test branch July 1, 2024 18:52
github-actions bot pushed a commit that referenced this pull request Jul 18, 2024
QMalcolm added a commit that referenced this pull request Jul 18, 2024
…misc deprecations (#10469)

* Tweak project-test-config deprecation test for misc deprecations (#10391)

(cherry picked from commit b59c907)

* Empty commit to trigger github actions

---------

Co-authored-by: Gerda Shank <[email protected]>
Co-authored-by: Quigley Malcolm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional logging for ephemeral model skipping
3 participants