Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9672: Artifact Schema Check #10069

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix #9672: Artifact Schema Check #10069

merged 2 commits into from
May 1, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented May 1, 2024

resolves #9672

Problem

Artifact schema check was failing and was running on all PRs

Solution

  1. Run only on PRs that change core/dbt/artifacts directory
  2. Upload artifact schema_changes.txt in case there is a failing run.

Example runs:

  1. Fail – https://github.com/dbt-labs/dbt-core/actions/runs/8910440719
  2. Skip – https://github.com/dbt-labs/dbt-core/actions/runs/8910475178

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label May 1, 2024
@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (a36057d) to head (a1376e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10069      +/-   ##
==========================================
+ Coverage   88.17%   88.19%   +0.01%     
==========================================
  Files         181      181              
  Lines       22700    22700              
==========================================
+ Hits        20016    20020       +4     
+ Misses       2684     2680       -4     
Flag Coverage Δ
integration 85.57% <ø> (+0.08%) ⬆️
unit 62.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review May 1, 2024 14:17
@aranke aranke requested a review from a team as a code owner May 1, 2024 14:17
@aranke aranke requested review from emmyoop and MichelleArk May 1, 2024 14:17
@aranke aranke merged commit 2e3c6fe into main May 1, 2024
63 checks passed
@aranke aranke deleted the fix_9672 branch May 1, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tech Debt] Fix artifact schema check
2 participants