Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paw/record final #10045

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Paw/record final #10045

merged 3 commits into from
Apr 26, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Apr 25, 2024

resolves https://dbtlabs.atlassian.net/browse/MNTL-275

Problem

We have added a record/replay mechanism to dbt, but there isn't a way to trigger it yet.

Solution

Add environment variables to activate record and replay mode.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Apr 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 88.14%. Comparing base (1014a6d) to head (6bf00df).
Report is 10 commits behind head on main.

Files Patch % Lines
core/dbt/cli/requires.py 72.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10045   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         181      181           
  Lines       22617    22665   +48     
=======================================
+ Hits        19935    19978   +43     
- Misses       2682     2687    +5     
Flag Coverage Δ
integration 85.44% <72.00%> (+<0.01%) ⬆️
unit 62.31% <72.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb marked this pull request as ready for review April 26, 2024 13:44
@peterallenwebb peterallenwebb requested a review from a team as a code owner April 26, 2024 13:44
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@peterallenwebb peterallenwebb merged commit f6b2cb7 into main Apr 26, 2024
64 checks passed
@peterallenwebb peterallenwebb deleted the paw/record-final branch April 26, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants