Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add script to override dev dependencies in tests #10023

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 24, 2024

resolves dbt-labs/dbt-common#104

Problem

Sometimes we want to test dbt-core in CI against branches of dependencies.

Solution

Add a script to update the dependencies in dev-requirements.txt

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner April 24, 2024 14:45
@cla-bot cla-bot bot added the cla:yes label Apr 24, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@@ -1,4 +1,4 @@
git+https://github.com/dbt-labs/dbt-adapters.git
git+https://github.com/dbt-labs/dbt-adapters.git@main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was accidentally changed in a previous PR - this just adds it back

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (0dc2a2f) to head (7092c37).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10023      +/-   ##
==========================================
- Coverage   88.19%   88.13%   -0.07%     
==========================================
  Files         181      181              
  Lines       22632    22632              
==========================================
- Hits        19961    19947      -14     
- Misses       2671     2685      +14     
Flag Coverage Δ
integration 85.43% <ø> (-0.14%) ⬇️
unit 62.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Apr 24, 2024
@emmyoop emmyoop merged commit 2325759 into main Apr 24, 2024
70 of 72 checks passed
@emmyoop emmyoop deleted the er/override-dependencies branch April 24, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [spike] Wrong commit used for core testing
2 participants