Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository unit tests to have Project fixture and do additional Project testing #10022

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

QMalcolm
Copy link
Contributor

resolves #9870

Problem

Writing unit tests is hard, so we're trying to build more fixtures that are common needs. The Project fixture is a commonly needed fixture, so adding it makes future writing of unit tests easier

Solution

Create a Project fixture in unit tests.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Apr 24, 2024
@QMalcolm QMalcolm requested a review from a team as a code owner April 24, 2024 04:35
@cla-bot cla-bot bot added the cla:yes label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (1014a6d) to head (39020d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10022      +/-   ##
==========================================
- Coverage   88.14%   88.13%   -0.01%     
==========================================
  Files         181      181              
  Lines       22617    22632      +15     
==========================================
+ Hits        19935    19947      +12     
- Misses       2682     2685       +3     
Flag Coverage Δ
integration 85.43% <ø> (-0.01%) ⬇️
unit 62.31% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"selectors": [
{
"name": "my_selector",
"definition": "give me cats",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈 🐈‍⬛

@QMalcolm QMalcolm merged commit 9a7be6d into main Apr 24, 2024
60 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--9870-project-unit-test-fixture branch April 24, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Project fixture and unit test Project class
3 participants