-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repository unit tests to have Project
fixture and do additional Project
testing
#10022
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10022 +/- ##
==========================================
- Coverage 88.14% 88.13% -0.01%
==========================================
Files 181 181
Lines 22617 22632 +15
==========================================
+ Hits 19935 19947 +12
- Misses 2682 2685 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tests/unit/config/test_project.py
Outdated
"selectors": [ | ||
{ | ||
"name": "my_selector", | ||
"definition": "give me cats", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐈 🐈⬛
resolves #9870
Problem
Writing unit tests is hard, so we're trying to build more fixtures that are common needs. The
Project
fixture is a commonly needed fixture, so adding it makes future writing of unit tests easierSolution
Create a
Project
fixture in unit tests.Checklist