Fix regression in semver comparison logic (#7040) (#7041)

(cherry picked from commit 915585c)

Co-authored-by: Jeremy Cohen <[email protected]>

.changes/unreleased/Fixes-20230224-001338.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fix semver comparison logic by ensuring numeric values
+time: 2023-02-24T00:13:38.23242+01:00
+custom:
+  Author: jtcohen6
+  Issue: "7039"

core/dbt/semver.py

@@ -152,9 +152,9 @@ def compare(self, other):
                 # else is equal and will fall through
 
             else:  # major/minor/patch, should all be numbers
-                if a > b:
+                if int(a) > int(b):
                     return 1
-                elif a < b:
+                elif int(a) < int(b):
                     return -1
                 # else is equal and will fall through
 

test/unit/test_semver.py

@@ -200,6 +200,14 @@ def test__resolve_to_specific_version(self):
                 ['1.0.0', '1.1.0a1', '1.1.0', '1.2.0a1', '1.2.0']),
             '1.1.0')
 
+        self.assertEqual(
+            resolve_to_specific_version(
+                # https://github.com/dbt-labs/dbt-core/issues/7039
+                # 10 is greater than 9
+                create_range('>0.9.0', '<0.10.0'),
+                ['0.9.0', '0.9.1', '0.10.0']),
+            '0.9.1')
+
     def test__filter_installable(self):
         installable = filter_installable(
             ['1.1.0',  '1.2.0a1', '1.0.0','2.1.0-alpha','2.2.0asdf','2.1.0','2.2.0','2.2.0-fishtown-beta','2.2.0-2'],