[Fix] raise execution errors for runnable tasks (#8237)

(cherry picked from commit 410506f)

.changes/unreleased/Fixes-20230728-115620.yaml

@@ -0,0 +1,7 @@
+kind: Fixes
+body: Ensure runtime errors are raised for graph runnable tasks (compile, show, run,
+  etc)
+time: 2023-07-28T11:56:20.863718-04:00
+custom:
+  Author: michelleark
+  Issue: "8166"

core/dbt/task/runnable.py

@@ -375,15 +375,17 @@ def execute_nodes(self):
                     )
 
             print_run_result_error(failure.result)
-            raise
+            # ensure information about all nodes is propagated to run results when failing fast
+            return self.node_results
         except KeyboardInterrupt:
             self._cancel_connections(pool)
             print_run_end_messages(self.node_results, keyboard_interrupt=True)
             raise
-        finally:
-            pool.close()
-            pool.join()
-            return self.node_results
+
+        pool.close()
+        pool.join()
+
+        return self.node_results
 
     def _mark_dependent_errors(self, node_id, result, cause):
         if self.graph is None:

tests/functional/compile/test_compile.py

@@ -164,6 +164,10 @@ def test_inline_fail(self, project):
         with pytest.raises(DbtException, match="Error parsing inline query"):
             run_dbt(["compile", "--inline", "select * from {{ ref('third_model') }}"])
 
+    def test_inline_fail_database_error(self, project):
+        with pytest.raises(DbtRuntimeError, match="Database Error"):
+            run_dbt(["show", "--inline", "slect asdlkjfsld;j"])
+
     def test_multiline_jinja(self, project):
         (results, log_output) = run_dbt_and_capture(["compile", "--inline", model_multiline_jinja])
         assert len(results) == 1

tests/functional/dependencies/test_local_dependency.py

@@ -13,7 +13,6 @@
 import dbt.semver
 import dbt.config
 import dbt.exceptions
-from dbt.contracts.results import RunStatus
 
 from dbt.tests.util import check_relations_equal, run_dbt, run_dbt_and_capture
 
@@ -208,9 +207,8 @@ def models(self):
 
     def test_missing_dependency(self, project):
         # dbt should raise a runtime exception
-        res = run_dbt(["compile"], expect_pass=False)
-        assert len(res) == 1
-        assert res[0].status == RunStatus.Error
+        with pytest.raises(dbt.exceptions.DbtRuntimeError):
+            run_dbt(["compile"])
 
 
 class TestSimpleDependencyWithSchema(BaseDependencyTest):

tests/functional/show/test_show.py

@@ -72,10 +72,13 @@ def test_inline_pass(self, project):
         assert "sample_bool" in log_output
 
     def test_inline_fail(self, project):
-        run_dbt(["build"])
         with pytest.raises(DbtException, match="Error parsing inline query"):
             run_dbt(["show", "--inline", "select * from {{ ref('third_model') }}"])
 
+    def test_inline_fail_database_error(self, project):
+        with pytest.raises(DbtRuntimeError, match="Database Error"):
+            run_dbt(["show", "--inline", "slect asdlkjfsld;j"])
+
     def test_ephemeral_model(self, project):
         run_dbt(["build"])
         (results, log_output) = run_dbt_and_capture(["show", "--select", "ephemeral_model"])