Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update macos runner #215

Merged
merged 1 commit into from
Nov 6, 2024
Merged

update macos runner #215

merged 1 commit into from
Nov 6, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 4, 2024

Description

macos-12 runner will be fully deprecated 12/3. Remove it before that happens.

Checklist

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Nov 4, 2024
@emmyoop emmyoop requested a review from a team as a code owner November 4, 2024 21:24
@cla-bot cla-bot bot added the cla:yes label Nov 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (65d7ba5) to head (48d5a73).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   68.48%   68.48%           
=======================================
  Files          52       52           
  Lines        3389     3389           
=======================================
  Hits         2321     2321           
  Misses       1068     1068           
Flag Coverage Δ
unit 68.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop
Copy link
Member Author

emmyoop commented Nov 4, 2024

This is blocked on dbt-labs/dbt-core#10974

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit bdf827a Nov 6, 2024
80 of 86 checks passed
@emmyoop emmyoop deleted the er/macos-ci branch November 6, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants