-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech Debt] Create connections subpackage #1390
Draft
mikealfare
wants to merge
12
commits into
main
Choose a base branch
from
create-connections-subpackage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rivate to indicate scope
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
connections
module has outgrown its container. There are many things in this module, and it makes it difficult to troubleshoot issues. Scope of impact for methods is not clear. As a result, we have created more connections-related functionality, but spread out across other modules and even subpackages. This led to things like multiple retry methods and treating python models and sql models as completely independent workflows.Solution
"Upgrade" the
connections.py
module to aconnections
subpackage and pull in other connections-related files to properly identify these features as connections features. This will allow us to much better encapsulate each feature and remove redundancy, thereby improving troubleshooting and ultimately decreasing bugs.This PR serves as the first iteration in that goal. The changes in this PR are largely structural and syntactic in nature:
/connections/
and mark them all as private/connections/__init__.py
and raise all members that are used outside of/connections/
Checklist