Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the PyPI version of core that gets installed as a sidecar for internal PyPI #747

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Remove the PyPI version of core that gets installed as a sidecar for internal PyPI #747

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01c4eb7
remove the pypi version of core that gets installed as a sidecar so t…
mikealfare Oct 22, 2024
6662858
remove the prerelease component of the version since we don't use tha…
mikealfare Oct 22, 2024
13c06ff
fix file reference for pyproject.toml, break script into smaller steps
mikealfare Oct 22, 2024
6c7f1dd
fix sed expression
mikealfare Oct 22, 2024
d44ffff
fix sed expression
mikealfare Oct 22, 2024
5476e14
fix version to be semver instead of hatch standard
mikealfare Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/publish-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ jobs:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
- id: package
run: echo "version=$(hatch version)" >> $GITHUB_OUTPUT
run: |
mikealfare marked this conversation as resolved.
Show resolved Hide resolved
# strip the pre-release off to find all iterations of this patch
hatch version release
echo "version=$(hatch version)" >> $GITHUB_OUTPUT
working-directory: ./${{ inputs.package }}
- id: published
run: |
Expand All @@ -70,10 +73,13 @@ jobs:
with:
version_number: ${{ steps.package.outputs.version }}
versions_published: ${{ steps.published.outputs.versions }}
- run: |
hatch version ${{ steps.next.outputs.internal_release_version }}+$(git rev-parse HEAD)
hatch build --clean
hatch run build:check-all
- name: "Update version to internal PyPI format"
mikealfare marked this conversation as resolved.
Show resolved Hide resolved
run: |
VERSION=${{ steps.next.outputs.internal_release_version }}+$(git rev-parse HEAD)
tee <<< "version = \"$VERSION\"" ./src/dbt/adapters/athena/__version__.py
working-directory: ./${{ inputs.package }}
- name: "Remove dbt-core from build requirements"
run: sed -i "/dbt-core[<>~=]/d" ./pyproject.toml
working-directory: ./${{ inputs.package }}
- run: |
export HATCH_INDEX_USER=${{ secrets.AWS_USER }}
Expand All @@ -90,5 +96,7 @@ jobs:
--output text \
--query repositoryEndpoint)

hatch build --clean
mikealfare marked this conversation as resolved.
Show resolved Hide resolved
hatch run build:check-all
hatch publish
working-directory: ./${{ inputs.package }}