Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dbt-glue LfTagsConfig compatibility #545

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: dbt-glue LfTagsConfig compatibility #545

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe92fdc
feat: dbt-glue LfTagsConfig compatibility
kagenihisomi Dec 20, 2023
9dc5e03
Merge branch 'main' into main
svdimchenko Feb 5, 2024
bb00577
Merge branch 'main' into main
svdimchenko Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dbt/adapters/athena/lakeformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
RemoveLFTagsFromResourceResponseTypeDef,
ResourceTypeDef,
)
from pydantic import BaseModel
from pydantic import BaseModel, root_validator

from dbt.adapters.athena.relation import AthenaRelation
from dbt.events import AdapterLogger
Expand All @@ -28,6 +28,15 @@ class LfTagsConfig(BaseModel):
tags_columns: Optional[Dict[str, Dict[str, List[str]]]] = None
inherited_tags: Optional[List[str]] = None

@root_validator(pre=True)
def alias_tags_table(cls, values):
# Allow for compatibility with dbt-glue (tags_table)
# https://github.com/aws-samples/dbt-glue/blob/ee2aa88663fd51ffc1ad1a1dbe04321206453386/dbt/adapters/glue/lakeformation.py#L12
tags_table = values.get('tags_table')
if tags_table:
values['tags'] = tags_table
del values['tags_table']
return values

class LfTagsManager:
def __init__(self, lf_client: LakeFormationClient, relation: AthenaRelation, lf_tags_config: LfTagsConfig):
Expand Down
Loading