Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): allows to use prj. vars #339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devmessias
Copy link

@devmessias devmessias commented Oct 29, 2024

resolves #
Resolves dbt-labs/dbt-core#5617, Resolves dbt-labs/dbt-core#10914

Problem

Python models are not friendly when we need to use project variables. This will allow to use project variables without to define that inside the model.yaml

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Oct 29, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@devmessias devmessias marked this pull request as ready for review October 31, 2024 19:31
@devmessias devmessias requested a review from a team as a code owner October 31, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant