Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query_id as optional to SQLQueryStatus proto + class #333

Closed
wants to merge 3 commits into from
Closed

Add query_id as optional to SQLQueryStatus proto + class #333

wants to merge 3 commits into from

Conversation

cmcarthur
Copy link
Member

@cmcarthur cmcarthur commented Oct 17, 2024 •
edited
Loading

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Oct 17, 2024
@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@cmcarthur cmcarthur mentioned this pull request Oct 17, 2024
Draft
4 tasks
colin-rogers-dbt
colin-rogers-dbt reviewed Oct 17, 2024
View reviewed changes
dbt/adapters/events/adapter_types.proto Outdated
@@ -266,6 +266,7 @@ message SQLQueryStatus {
AdapterNodeInfo node_info = 1;
string status = 2;
float elapsed = 3;
optional string query_id = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't protobuf fields optional by default?

@cmcarthur cmcarthur force-pushed the cmcarthur/add-query-id-to-sqlquerystatus branch from 49db348 to 26a01a8 Compare October 30, 2024 14:21
@cmcarthur cmcarthur changed the title add query_id as optional to SQLQueryStatus Add query_id as optional to SQLQueryStatus proto + class Oct 30, 2024
@cmcarthur cmcarthur marked this pull request as ready for review October 30, 2024 14:32
@cmcarthur cmcarthur requested a review from a team as a code owner October 30, 2024 14:32
@cmcarthur
Copy link
Member Author

closing as duplicate of #342

@cmcarthur cmcarthur closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmcarthur @colin-rogers-dbt