Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 186 #322

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Test 186 #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0cdca13
Update replace.sql
rongfengliang Apr 25, 2024
2b40da5
add CHANGELOG
rongfengliang Apr 25, 2024
a4badba
Merge branch 'main' into patch-1
rongfengliang Apr 27, 2024
b93f056
Merge branch 'main' into patch-1
dbeatty10 May 14, 2024
8c8290c
Merge branch 'main' into patch-1
mikealfare May 15, 2024
aaa6f05
Merge branch 'main' into patch-1
colin-rogers-dbt Aug 9, 2024
fbe5719
Update Fixes-20240425-133610.yaml
rongfengliang Aug 10, 2024
109f72b
Merge branch 'main' into patch-1
colin-rogers-dbt Sep 27, 2024
0205e32
Merge branch 'main' into test-186
colin-rogers-dbt Oct 11, 2024
5812a2e
merge main
colin-rogers-dbt Oct 31, 2024
887e5db
Merge branch 'main' into test-186
colin-rogers-dbt Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20240425-133610.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix is_replaceable check with wrong variable
time: 2024-04-25T13:36:10.684598+08:00
custom:
Author: rongfengliang
Issue: "187"
1 change: 1 addition & 0 deletions dbt/adapters/contracts/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,3 +226,4 @@ class AdapterRequiredConfig(HasCredentials, Protocol):
cli_vars: Dict[str, Any]
target_path: str
log_cache_events: bool
catalogs = Optional[ExternalCatalogConfig]
2 changes: 1 addition & 1 deletion dbt/include/global_project/macros/relations/replace.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

{# /* use a create or replace statement if possible */ #}

{% set is_replaceable = existing_relation.type == target_relation_type and existing_relation.can_be_replaced %}
{% set is_replaceable = existing_relation.type == target_relation.type and existing_relation.can_be_replaced %}

{% if is_replaceable and existing_relation.is_view %}
{{ get_replace_view_sql(target_relation, sql) }}
Expand Down
Loading