Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard_deletes config and new_record Option for Snapshots #317

Merged
merged 15 commits into from
Nov 22, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Sep 26, 2024

resolves dbt-labs/dbt-core#10235

The corresponding dbt-core PR adds the new configuration values: dbt-labs/dbt-core#10972

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 26, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb marked this pull request as ready for review November 4, 2024 17:05
@peterallenwebb peterallenwebb requested a review from a team as a code owner November 4, 2024 17:05
gshank
gshank previously approved these changes Nov 4, 2024
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, some of them maybe speaking to my ignorance when it comes to the snapshot materialization. Aside from that, will there be tests associated with this change? I would have expected some updates in dbt-tests-adapter in this PR as well as a PR in something like dbt-postgres that points to this branch.

Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@peterallenwebb
Copy link
Contributor Author

@colin-rogers-dbt I'm discussing the testing strategy with @mikealfare now. I'm adding tests in dbt-core, which is where most of the snapshot testing infrastructure already exists. I'm willing to try to get some of that infrastructure moved over into this repo, and I think that makes sense, but I'm worried that gating on that could jeopardize getting this into 1.9rc1, @graciegoheen.

mikealfare
mikealfare previously approved these changes Nov 22, 2024
@peterallenwebb peterallenwebb dismissed colin-rogers-dbt’s stale review November 22, 2024 19:54

I have addressed the change request by adding a test!

@mikealfare
Copy link
Contributor

@cla-bot check

@mikealfare
Copy link
Contributor

@peterallenwebb is a member of dbt Labs, hence has signed the CLA. Merging without this branch check running by manual confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new record in snapshot to track deleted state (is_deleted column, zombie records)
4 participants