Null-safe equality for unique_key within delete+insert and merge incremental strategies

.changes/unreleased/Fixes-20240227105926.yaml

@@ -0,0 +1,7 @@
+kind: Fixes
+body: Fix incremental merge to use an `is null` check to allow for handling of nullable
+  fields in the unique_key
+time: 2024-02-27T10:59:59.202000+00:00
+custom:
+  Author: amardatar
+  Issue: "7597"

dbt-tests-adapter/dbt/tests/adapter/incremental/test_incremental_unique_id.py

@@ -240,6 +240,8 @@
 select 'NY','New York','Manhattan','2021-04-01'
 union all
 select 'PA','Philadelphia','Philadelphia','2021-05-21'
+union all
+select 'CO','Denver',null,'2021-06-18'
 
 """
 
@@ -265,6 +267,8 @@
 select 'NY','New York','Manhattan','2021-04-01'
 union all
 select 'PA','Philadelphia','Philadelphia','2021-05-21'
+union all
+select 'CO','Denver',null,'2021-06-18'
 
 """
 
@@ -288,6 +292,7 @@
 NY,Kings,Brooklyn,2021-04-02
 NY,New York,Manhattan,2021-04-01
 PA,Philadelphia,Philadelphia,2021-05-21
+CO,Denver,,2021-06-18
 """
 
 seeds__add_new_rows_sql = """

dbt/include/global_project/macros/materializations/models/incremental/merge.sql

@@ -16,13 +16,13 @@
         {% if unique_key is sequence and unique_key is not mapping and unique_key is not string %}
             {% for key in unique_key %}
                 {% set this_key_match %}
-                    DBT_INTERNAL_SOURCE.{{ key }} = DBT_INTERNAL_DEST.{{ key }}
+                    DBT_INTERNAL_SOURCE.{{ key }} = DBT_INTERNAL_DEST.{{ key }} or (DBT_INTERNAL_SOURCE.{{ key }} is null and DBT_INTERNAL_DEST.{{ key }} is null)
                 {% endset %}
                 {% do predicates.append(this_key_match) %}
             {% endfor %}
         {% else %}
             {% set unique_key_match %}
-                DBT_INTERNAL_SOURCE.{{ unique_key }} = DBT_INTERNAL_DEST.{{ unique_key }}
+                DBT_INTERNAL_SOURCE.{{ unique_key }} = DBT_INTERNAL_DEST.{{ unique_key }} or (DBT_INTERNAL_SOURCE.{{ unique_key }} is null and DBT_INTERNAL_DEST.{{ unique_key }} is null)
             {% endset %}
             {% do predicates.append(unique_key_match) %}
         {% endif %}
@@ -62,12 +62,12 @@
 
     {% if unique_key %}
         {% if unique_key is sequence and unique_key is not string %}
-            delete from {{target }}
+            delete from {{ target }}
             using {{ source }}
             where (
                 {% for key in unique_key %}
-                    {{ source }}.{{ key }} = {{ target }}.{{ key }}
-                    {{ "and " if not loop.last}}
+                    ({{ source }}.{{ key }} = {{ target }}.{{ key }} or ({{ source }}.{{ key }} is null and {{ target }}.{{ key }} is null))
+                    {{ "and " if not loop.last }}
                 {% endfor %}
                 {% if incremental_predicates %}
                     {% for predicate in incremental_predicates %}