Adap 108/fix renamed relations for 1.8 (#109)

Co-authored-by: Mila Page <[email protected]> Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Mike Alfare <[email protected]>
dbt-labs · Mar 21, 2024 · 59cb168 · 59cb168
1 parent 35bd362
commit 59cb168
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/.changes/unreleased/Fixes-20240226-224046.yaml b/.changes/unreleased/Fixes-20240226-224046.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Add field wrapper to BaseRelation members that were missing it.
+time: 2024-02-26T22:40:46.271694-08:00
+custom:
+  Author: versusfacit
+  Issue: "108"
diff --git a/dbt/adapters/base/relation.py b/dbt/adapters/base/relation.py
@@ -52,13 +52,13 @@ class BaseRelation(FakeAPIObject, Hashable):
     # adding a relation type here also requires defining the associated rename macro
     # e.g. adding RelationType.View in dbt-postgres requires that you define:
     # include/postgres/macros/relations/view/rename.sql::postgres__get_rename_view_sql()
-    renameable_relations: SerializableIterable = ()
+    renameable_relations: SerializableIterable = field(default_factory=frozenset)
 
     # register relation types that are atomically replaceable, e.g. they have "create or replace" syntax
     # adding a relation type here also requires defining the associated replace macro
     # e.g. adding RelationType.View in dbt-postgres requires that you define:
     # include/postgres/macros/relations/view/replace.sql::postgres__get_replace_view_sql()
-    replaceable_relations: SerializableIterable = ()
+    replaceable_relations: SerializableIterable = field(default_factory=frozenset)
 
     def _is_exactish_match(self, field: ComponentName, value: str) -> bool:
         if self.dbt_created and self.quote_policy.get_part(field) is False:

diff --git a/dbt/include/global_project/macros/relations/materialized_view/drop.sql b/dbt/include/global_project/macros/relations/materialized_view/drop.sql
@@ -5,7 +5,7 @@ actually executes the drop, and `get_drop_sql`, which returns the template.
 */ #}
 
 {% macro drop_materialized_view(relation) -%}
-    {{ return(adapter.dispatch('drop_materialized_view', 'dbt')(relation)) }}
+    {{- adapter.dispatch('drop_materialized_view', 'dbt')(relation) -}}
 {%- endmacro %}
 
 

diff --git a/dbt/include/global_project/macros/relations/table/drop.sql b/dbt/include/global_project/macros/relations/table/drop.sql
@@ -5,7 +5,7 @@ actually executes the drop, and `get_drop_sql`, which returns the template.
 */ #}
 
 {% macro drop_table(relation) -%}
-    {{ return(adapter.dispatch('drop_table', 'dbt')(relation)) }}
+    {{- adapter.dispatch('drop_table', 'dbt')(relation) -}}
 {%- endmacro %}
 
 

diff --git a/dbt/include/global_project/macros/relations/view/drop.sql b/dbt/include/global_project/macros/relations/view/drop.sql
@@ -5,7 +5,7 @@ actually executes the drop, and `get_drop_sql`, which returns the template.
 */ #}
 
 {% macro drop_view(relation) -%}
-    {{ return(adapter.dispatch('drop_view', 'dbt')(relation)) }}
+    {{- adapter.dispatch('drop_view', 'dbt')(relation) -}}
 {%- endmacro %}