#1570 Add degree range evolution operator #1582
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwba
changed the title
ChrizZz110
requested changes
Aug 12, 2022
| @Before | ||
| public void setUp() throws Exception { | ||
| testGraph = getTestGraphWithValues(); | ||
| Collection<Tuple2<GradoopId, String>> idLabelCollection = new HashSet<>(); |
| opt = vertexDegrees.values().stream().reduce(Math::max); | ||
| opt.ifPresent(integer -> collector.collect(new Tuple2<>(timePoint, integer))); | ||
| break; | ||
| case AVG: |
There was a problem hiding this comment.
Does not belong in this Branch
| case RANGE: | ||
| opt = vertexDegrees.values().stream().reduce(Math::max); | ||
| opt2 = vertexDegrees.values().stream().reduce(Math::min); | ||
| opt.flatMap(max -> opt2.map(min -> max - min)); |
There was a problem hiding this comment.
This is not working. It does not change the value of the opt. Since the expected values in the UnitTests are wrong for BOTH, t4, you were possibly not aware of this.
There was a problem hiding this comment.
int maxDegree = vertexDegrees.values().stream().reduce(Math::max).orElse(0);
int minDegree = vertexDegrees.values().stream().reduce(Math::min).orElse(0);
collector.collect(new Tuple2<>(timePoint, maxDegree - minDegree));
| // DEGREES | ||
| EXPECTED_BOTH_DEGREES.add(new Tuple2<>(Long.MIN_VALUE, 0)); | ||
| EXPECTED_BOTH_DEGREES.add(new Tuple2<>(0L, 1)); | ||
| EXPECTED_BOTH_DEGREES.add(new Tuple2<>(4L, 3)); |
There was a problem hiding this comment.
The expected value should be 2 here, since max is 3 and min is 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of Changes
Checklist: