Adds makefiles include directory to recursive make invocations #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to propagate the INCLUDE_MAKEFILES so that we only have to modify the root Makefile in an old (MIUN) repo.
|
Maybe this would be nice to have in general? E.g. ../%:
${MAKE} -I ${INCLUDE_MAKEFILES} -C $(dir $@) $(notdir $@)might work. Or more generally %:
[ -z "$(dir $@)" ] && ${MAKE} -I ${INCLUDE_MAKEFILES} -C $(dir $@) $(notdir $@)However, the latter must be placed at the very end of all includes, which is difficult to ensure in an include. |
|
A better solution (documented here): MAKEFLAGS+= -I ${INCLUDE_MAKEFILES}The question is in which include file to put this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we call
MAKEinsubdir.mkwe will add-I ${INCLUDE_MAKEFILES}. This allows us to have makefiles in the subdirectories which have not setINCLUDE_MAKEFILES(e.g. old MIUN makefiles).