Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Swedish translation #1080

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

IsakTheHacker
Copy link
Contributor

No description provided.

@dborth
Copy link
Owner

dborth commented Jan 13, 2024

This won't work just on its own - some minor code changes need to be made to add Swedish as an option.

@IsakTheHacker
Copy link
Contributor Author

IsakTheHacker commented Jan 13, 2024 via email

@IsakTheHacker
Copy link
Contributor Author

One more question, are the language files for your other emulator (fceugx) exactly the same? They seem very similar

@dborth
Copy link
Owner

dborth commented Jan 21, 2024

I can make the changes to add Swedish.

Both vbagx and fceugx share the same project structure and so what a number of the other translators have done is create one translation file to be shared by all three, since additional translation strings that aren't used are harmless. A lot of the language used is the same in all 3 as possible so it's mostly only emulator-specific translations that differ.

@dborth dborth merged commit f6d1477 into dborth:master Jan 21, 2024
3 checks passed
@dborth
Copy link
Owner

dborth commented Jan 21, 2024

Try the pre-release and see if everything works!

https://github.com/dborth/snes9xgx/releases

@IsakTheHacker IsakTheHacker deleted the swedish-translation branch January 22, 2024 16:54
@IsakTheHacker
Copy link
Contributor Author

Great! I have opened pull requests in vbagx and fceugx now to add Swedish translations. The file that I initially based my translations on (fr.lang) already included nes and gameboy advance translations. I can't really test that everything works at the moment though, but all translations should be correct. Is there any way to assert at compile time that all language resources are present?

@dborth
Copy link
Owner

dborth commented Jan 23, 2024

Thanks for the contributions! No there's no way to know that all strings are accounted for except by reviewing the source code and comparing to the translation file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants