IIIF v3 seeAlso and textual AnnotationPage support #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l OCR resources
jbaiter
requested changes
Nov 8, 2021
| * @param annotationJson Annotation-like json sturct | ||
| */ | ||
| const naiveIIIFv3Check = (annotationJson) => | ||
| annotationJson && annotationJson.type && annotationJson.type === 'AnnotationPage'; |
There was a problem hiding this comment.
Suggested change
| annotationJson && annotationJson.type && annotationJson.type === 'AnnotationPage'; | |
| annotationJson?.type === 'AnnotationPage'; |
| @@ -123,7 +130,22 @@ export async function fetchAnnotationResource(url) { | |||
| } | |||
|
|
|||
| /** Saga for fetching external annotation resources */ | |||
| export function* fetchExternalAnnotationResources({ targetId, annotationId, annotationJson }) { | |||
| export function fetchExternalAnnotationResources({ targetId, annotationId, annotationJson }) { | |||
There was a problem hiding this comment.
Are you sure that this is working as expected? This should be a Generator that yields Redux-Saga effects and not a plain function.
There was a problem hiding this comment.
Thank you for pointing this out. I did thorougly test the seeAlso variant and only checked the "inline" one.
| /** Saga for processing texts from IIIF annotations */ | ||
| export function* processTextsFromAnnotations({ targetId, annotationId, annotationJson }) { | ||
| export function processTextsFromAnnotations({ targetId, annotationId, annotationJson }) { |
There was a problem hiding this comment.
See above, is this working as expected?
|
Thanks, @jbaiter for your review. I will work on the requested changes during this week and especially try to come up with a dedicated IIIF v3 collection JSON for testing and demo purposes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
seeAlsosupport oncanvas-level for IIIF v3 manifests as well as "inline" resources, such assupplementingannotaitons with a body ofTextualBody.This at least partially addresses #186
There is one caveat though, as of right now, I did not manage to get the tests running, which might be due to some minor refactoring on my side. Contributions are welcome.