Shrieking hat #586
Open
Shrieking hat #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto shrieking-hat # Conflicts: # CHANGELOG.md
acourrau
requested changes
Dec 5, 2020
| return false; | ||
|
|
||
| OldBookPower po = null; | ||
| // requested that death preventing cards trigger in order of pickup. | ||
| SortedSet<DeathPreventionCard> deathPreventionCards = new TreeSet<>(Comparator.comparingInt(DeathPreventionCard::getPriority)); |
There was a problem hiding this comment.
With the change suggested above, we should be able to loop the masterDeck object first to determine "permanent" cards that were added to the deck that need to be consumed, and then pursue the "temporary" cards using your priority implemented.
There was a problem hiding this comment.
It added a little bit more complexity to the the logic, but I think it should work as expected.
…nto shrieking-hat
…or death prevention cards then add them to the sorted set.
… dies without shrieking hat in hand. Old book should trigger in that case.
…ombat (pots, discovery, nilry's, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shrieking Hat - Unplayable, Retain, When you die instead deal all damage taken while this was in your hand to all enemies and destroy this.
Upgrades to +3 damage
Shrieking Hat card art was already in the code base apparently.