Relic stats mod support #533
Conversation
| @@ -53,6 +55,9 @@ public void update() { | |||
| AbstractPower p = this.target.getPower(BurningPower.POWER_ID); | |||
| if (p != null) { | |||
| p.amount = BurningUtils.calculateNextBurningAmount(source, p.amount); | |||
| if(source != null && source.isPlayer && ((AbstractPlayer) source).hasRelic(AlchemistsFireRelic.ID)) { | |||
| ((AlchemistsFireRelic) ((AbstractPlayer) source).getRelic(AlchemistsFireRelic.ID)).updateStats(p.amount); | |||
There was a problem hiding this comment.
I don't think this is increasing the relics counter by the correct amount. This increases it by the amount of burning currently on enemies, rather than the difference in reduced burning.
10 burning without relic goes to 6
10 burning with relic goes to 9
This = a saving of 3 burning. Relic displays 9.
Should be simple enough to calculate the difference when increasing the counter amount.
| 1, | ||
| true)); | ||
| } | ||
| PreAoeDamageStatsAction preAoeDamageStatsAction = new PreAoeDamageStatsAction(); | ||
| AbstractDungeon.actionManager.addToBottom(preAoeDamageStatsAction); | ||
| AbstractDungeon.actionManager.addToBottom( | ||
| new DamageAllEnemiesAction( |
There was a problem hiding this comment.
If this damage kills all the enemies and ends the fight, the relic stats don't get updated properly. I think this might just need one of the calls below to be made in a different order or in a different spot.
There was a problem hiding this comment.
I thought I checked this scenario. It should be.... Guess I'll take a look at this again.
There was a problem hiding this comment.
Well, there's a bug with the console command clarify all that doesn't trigger the MindGlassPower. Makes for testing this harder than expected.
So far, I haven't seen the 3 damage to all update incorrectly. This should basically be the same as what the RelicMod does. Could you show a scenario where you got that?
I'll keep looking into the 100 damage
There was a problem hiding this comment.
100 damage doesn't work quite right with Arcane Form and memory clarify all. filed #549
There was a problem hiding this comment.
well, there's an issue where it's not adding the "times 100 clarities correctly"
There was a problem hiding this comment.
It's a pain, but use the dev console to do:
memory clarify stsjorbsmod:.....
memory clarify stsjorbsmod:.....
memory clarify stsjorbsmod:.....
And if that damage kills all enemies it doesnt appear the count gets updated, for the 100 damage amount. The 3 damage one appears to work fine.
| float amountHealed = (float) stats.get(STAT_AMOUNT_HEALED); | ||
| return new StringBuilder() | ||
| .append(getStatsDescription()) | ||
| .append(String.format(STAT_PER_TURN, STATS_FORMAT.format(amountHealed / Math.max(totalTurns, 1)))) |
There was a problem hiding this comment.
Seeing some oddities with the totalTurns and totalCombats counts. They're far higher than I expected and I think they're skewing the stats.
There was a problem hiding this comment.
I'm not sure what I can do about totalTurns and totalCombats here. These are coming from the stats mod.
There was a problem hiding this comment.
No problem then, just worth mentioning.
|
Closing in favor of #558 |
Supports Relic Stats Mod by ForgottenArbiter/Quincunx
Steam Workshop: https://steamcommunity.com/sharedfiles/filedetails/?id=2118491069
GitHub: https://github.com/ForgottenArbiter/StsRelicStats
Relics with stats:
Feel free to comment on other useful stats from other existing relics.