Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CircleCI to GitHub Actions #162

Merged
merged 17 commits into from
Jan 8, 2024

Conversation

mwallace582
Copy link
Collaborator

@mwallace582 mwallace582 commented Jan 6, 2024

resolves #120

Description

Migrate Circle CI lint, unit, and integration tests to GitHub Actions

dbt-snowflake and dbt-bigquery were used as inspiration for these changes, and I've updated this repo in many places to more closely follow those examples.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md with information about my change

* Add support for unit tests
* Update dependencies to match `dbt-snowflake`
* Update tox config to match `dbt-snowflake`
* Update setup.py to match `dbt-snowflake`
@mwallace582 mwallace582 self-assigned this Jan 6, 2024
* Unlike other DBT adapters, this one contains support for three
  different flavors of MySQL, thus has a handful of duplicate files.
  Therefore W002 should be ignored, as duplicates are not an error.
* Used `dbt-snowflake` as an example
@mwallace582 mwallace582 added the ok to test This pull request can run integration tests label Jan 7, 2024
@mwallace582
Copy link
Collaborator Author

Integration tests won't run on this PR because the pull_request_target workflow requires that the test infrastructure has merged to the destination before tests can run.

I did verify that these tests run and pass in an earlier commit where I temporarily specified the pull_request workflow instead.

@mwallace582 mwallace582 marked this pull request as ready for review January 8, 2024 18:14
@mwallace582 mwallace582 requested a review from dbeatty10 January 8, 2024 18:14
@mwallace582 mwallace582 changed the title Draft: Migrate CircleCI to GitHub Actions Migrate CircleCI to GitHub Actions Jan 8, 2024
Copy link
Owner

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome @mwallace582 🚀

Thanks for your work on this.

Comment on lines +3 to +4
# git+https://github.com/dbt-labs/[email protected]#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/[email protected]#egg=dbt-tests-adapter&subdirectory=tests/adapter
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future: depending on the version number of the next release of dbt-mysql, we'll need to change 1.4.latest to match that version.

@dbeatty10 dbeatty10 merged commit 22de9fe into main Jan 8, 2024
5 checks passed
@dbeatty10 dbeatty10 mentioned this pull request Jan 11, 2024
@mwallace582 mwallace582 mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test This pull request can run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CircleCI to GitHub Actions
2 participants