-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated vscode settings and added recommended extensions #53
chore: updated vscode settings and added recommended extensions #53
Conversation
…o hide node_modules folders.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request introduces configuration changes to the Visual Studio Code workspace settings. A new recommended extension for Prettier is added to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.vscode/settings.json (3)
4-6
: Consider adding more common excludes.While hiding
node_modules
is good, consider adding other common excludes for a cleaner workspace:"files.exclude": { - "**/node_modules": true + "**/node_modules": true, + "**/.git": true, + "**/.DS_Store": true, + "**/dist": true, + "**/coverage": true }
7-7
: Consider adding more Prettier configurations.While setting
singleQuote
is good, consider adding other common Prettier configurations for better consistency:-"prettier.singleQuote": false, +"prettier.singleQuote": false, +"prettier.trailingComma": "es5", +"prettier.printWidth": 100, +"prettier.tabWidth": 2, +"prettier.semi": true
8-10
: Consider adding more search excludes.While excluding
node_modules
from search is good, consider adding other common excludes to improve search performance:"search.exclude": { - "**/node_modules": true + "**/node_modules": true, + "**/dist": true, + "**/coverage": true, + "**/.git": true, + "package-lock.json": true }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.vscode/extensions.json
(1 hunks).vscode/settings.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .vscode/extensions.json
🔇 Additional comments (2)
.vscode/settings.json (2)
2-3
: LGTM! Good formatting configuration.The configuration enforces consistent code formatting by setting Prettier as the default formatter and enabling format on save. This aligns well with the recommended extensions in
.vscode/extensions.json
.
11-11
: LGTM! Good TypeScript configuration.Using the workspace's TypeScript version is a good practice as it ensures consistency between developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
prettier.config.cjs (3)
10-23
: Consider standardizing tab width across all file types.The configuration sets different tab widths (4 spaces globally vs 2 spaces for YAML/Markdown), which could lead to inconsistent code appearance across the project. While YAML and Markdown files commonly use 2 spaces, consider standardizing to 2 spaces project-wide for consistency.
module.exports = { endOfLine: "lf", semi: true, singleQuote: false, - tabWidth: 4, + tabWidth: 2, trailingComma: "es5", bracketSpacing: true, printWidth: 80, - overrides: [ - { - files: ["*.yaml", "*.yml"], - options: { - tabWidth: 2, - }, - }, - { - files: ["*.md"], - options: { - tabWidth: 2, - }, - }, - ], };
10-16
: Consider additional YAML-specific formatting options.For YAML files, you might want to consider additional formatting options that are commonly used:
{ files: ["*.yaml", "*.yml"], options: { tabWidth: 2, + proseWrap: "preserve", + bracketSpacing: false }, },
17-22
: Consider additional Markdown-specific formatting options.For Markdown files, you might want to consider additional formatting options that improve readability:
{ files: ["*.md"], options: { tabWidth: 2, + proseWrap: "always", + embeddedLanguageFormatting: "auto" }, },
.vscode/extensions.json
file that contains recommendationded extensions used by the project.Summary by CodeRabbit
node_modules
from file operations and search results.