Increase YNAB max lengths to follow API changes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidstosik
force-pushed
the
sto/max-length
branch
from
b2f0898 to
243b60b
Compare
|
Rebased. (For the record, I kept a backup of the old branch at |
|
@balvig Would you mind giving this a try? |
davidstosik
force-pushed
the
sto/max-length
branch
from
243b60b to
053bfe2
Compare
davidstosik
force-pushed
the
sto/max-length
branch
from
053bfe2 to
1248ff5
Compare
|
Works for me! 👏 |
davidstosik
added a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Increase YNAB memo and payee name limits to 500 and 200 characters respectively.
Why?
The API will be updated soon to allow for longer memo and payee names.
See ynab/ynab-sdk-ruby#77 for more details.
How?
Extract "magic numbers" to constants, then update their values.
What else?
This can't be merged until the changes have been made to YNAB's API (server and client?).
This PR may come with a gem update too.