Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support arbitrary env-vars #52

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

davidkarlsen
Copy link
Owner

@davidkarlsen davidkarlsen commented Nov 13, 2023

Fixes #11

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8958d7) 73.80% compared to head (1e9c90a) 73.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   73.80%   73.93%   +0.12%     
==========================================
  Files           2        2              
  Lines         210      211       +1     
==========================================
+ Hits          155      156       +1     
  Misses         46       46              
  Partials        9        9              
Files Coverage Δ
internal/controller/jobutil.go 91.05% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkarlsen davidkarlsen merged commit daf8605 into main Nov 13, 2023
6 checks passed
@davidkarlsen davidkarlsen deleted the feature/add-arbitrary-configs branch November 13, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setting arbitrary config params
1 participant