Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix sleep breaks oauth1 signature #595

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jeroenvermeulen
Copy link

After quite some debugging I found out the __sleep function in OAuth\Common\Token\AbstractToken breaks the signature in Oauth1.

Example usage:
```php
class OauthClient extends \OAuth\OAuth1\Service\AbstractService
{
    public function __construct(
        Credentials $credentials,
        ClientInterface $httpClient = null,
        TokenStorageInterface $storage = null,
        SignatureInterface $signature = null,
        UriInterface $baseApiUri = null
    ) {
        $this->setSignatureMethod('HMAC-SHA256');  // <== THIS
        parent::__construct($credentials, $httpClient, $storage, $signature, $baseApiUri);
    }
}
```
Implemented HMAC-SHA256 signature support to OAuth1.
…Common\Token\AbstractToken breaks the signature in Oauth1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant