Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #179

Merged
merged 1 commit into from
Jan 7, 2024
Merged

[email protected] #179

merged 1 commit into from
Jan 7, 2024

Conversation

davidchambers
Copy link
Owner

https://github.com/sanctuary-js/sanctuary-scripts/releases/tag/v7.0.0

Unfortunately we're not (yet) able to remove our custom test script as we need to specify --experimental-vm-modules.

The updated test script is a slightly modified version of the canonical one:

$ diff <(curl -Ls https://github.com/sanctuary-js/sanctuary-scripts/raw/v7.0.0/bin/test) scripts/test
4,6c4
< source "$(dirname "$(dirname "$(realpath "${BASH_SOURCE[0]}")")")/functions"
< 
< run_custom_script test "$@"
---
> source "$(dirname "$(dirname "$(realpath "${BASH_SOURCE[0]}")")")/node_modules/sanctuary-scripts/functions"
27c25
< node_modules/.bin/c8 "${args[@]}" -- node_modules/.bin/oletus -- "${test_files[@]}"
---
> node_modules/.bin/c8 "${args[@]}" -- node --experimental-vm-modules -- node_modules/.bin/oletus -- "${test_files[@]}"

@davidchambers davidchambers requested a review from Avaq January 7, 2024 11:54
Comment on lines -33 to -34
"c8": "8.0.x",
"oletus": "4.0.x",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies are now included. :)

@davidchambers davidchambers merged commit 44ef397 into main Jan 7, 2024
6 checks passed
@davidchambers davidchambers deleted the sanctuary-scripts branch January 7, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants