Skip to content

Commit

Permalink
darcys22GH-49 disable (for now) the mysql tests in ci.yml
Browse files Browse the repository at this point in the history
no point in running the mysql integration tests until
they are actually testing the evaluators
  • Loading branch information
davidalpert committed May 8, 2021
1 parent 977c27d commit d373b0f
Showing 1 changed file with 37 additions and 36 deletions.
73 changes: 37 additions & 36 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,39 +41,40 @@ jobs:
run: go run utils/ci.go build
- name: Test
run: go run utils/ci.go test --integration -v
mysqltest:
strategy:
fail-fast: false # dont' want one scenario failing to deprive us of feedback on the others
matrix:
go-version: [1.14.x, 1.15.x]
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
services:
mysql:
image: mysql:5.7
env:
MYSQL_USER: godbledger
MYSQL_PASSWORD: password
MYSQL_DATABASE: ledger
MYSQL_ROOT_PASSWORD: password
ports:
- 3306
options: --health-cmd="mysqladmin ping" --health-interval=10s
steps:
- name: Verify MySQL connection
env:
PORT: ${{ job.services.mysql.ports[3306] }}
run: |
while ! mysqladmin ping -h"127.0.0.1" -P"$PORT" --silent; do
sleep 1
done
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v2
- name: Build
run: go run utils/ci.go build
- name: Test
run: go run utils/ci.go test --mysql -v
# TODO: these mysql test currently bypass the end-to-end test pattern effectively testing only that configuration is loaded
# mysqltest:
# strategy:
# fail-fast: false # dont' want one scenario failing to deprive us of feedback on the others
# matrix:
# go-version: [1.14.x, 1.15.x]
# os: [ubuntu-latest]
# runs-on: ${{ matrix.os }}
# services:
# mysql:
# image: mysql:5.7
# env:
# MYSQL_USER: godbledger
# MYSQL_PASSWORD: password
# MYSQL_DATABASE: ledger
# MYSQL_ROOT_PASSWORD: password
# ports:
# - 3306
# options: --health-cmd="mysqladmin ping" --health-interval=10s
# steps:
# - name: Verify MySQL connection
# env:
# PORT: ${{ job.services.mysql.ports[3306] }}
# run: |
# while ! mysqladmin ping -h"127.0.0.1" -P"$PORT" --silent; do
# sleep 1
# done
# - name: Install Go
# uses: actions/setup-go@v2
# with:
# go-version: ${{ matrix.go-version }}
# - name: Checkout code
# uses: actions/checkout@v2
# - name: Build
# run: go run utils/ci.go build
# - name: Test
# run: go run utils/ci.go test --mysql -v

0 comments on commit d373b0f

Please sign in to comment.