-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom client #29
Custom client #29
Conversation
b31d017
to
2ebb944
Compare
There is an issue regarding auth responses as they are wrapped in an object. This makes typing it kind of annoying. I'll try to find a good way to solve this, but maybe i'll delay this so i can release version |
I noticed an issue with sorts and filters. It seems the npm package is somehow inconsistent: Also the assignment of filters seems to be missing in prepareOptions so filters are not doing anything right now. |
New api!
Instead of using functions to create filters and more i decided to create a custom client instead.
"Code says more than words":
You can now create your filters, sort and select values beforehand:
I personally think this is the way to go. The main benefits are:
view
base
andauth
collections are correctly typed!