Skip to content

Commit

Permalink
chore: replace standard with eslint-config-standard and add custom ru…
Browse files Browse the repository at this point in the history
…les (electron#14636)

* chore: replace standard with eslint-config-standard

This adds support for --cache so linting JS only takes ~1 second and only lints things that changed

It also allows us to add custom linting rules

* chore: add eslint-plugin-mocha and enable the no-exclusive-tests rule

This will block anyone from pushing / merging a `.only` test or describe
  • Loading branch information
MarshallOfSound authored Sep 15, 2018
1 parent 7065093 commit 6d01952
Show file tree
Hide file tree
Showing 10 changed files with 452 additions and 56 deletions.
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
vendor
node_modules
spec/node_modules
spec/static
6 changes: 6 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "standard",
"env": {
"browser": true
}
}
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,6 @@ electron.d.ts

# Spec hash calculation
spec/.hash

# Eslint Cache
.eslintcache
2 changes: 1 addition & 1 deletion lib/common/asar_init.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
;(function () {
;(function () { // eslint-disable-line
return function (process, require, asarSource) {
const source = process.binding('natives')

Expand Down
Loading

0 comments on commit 6d01952

Please sign in to comment.