Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /norestart flag #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Geogboe
Copy link

@Geogboe Geogboe commented Jun 12, 2024

Thanks for maintaining this package! I had one small suggestion: the DUO installer currently will forceably restart the local machine if needed. This can be unpredictable. Adding the /norestart flag gives you flexibility to restart at your convenience. Also, from my testing duo doesn't really need a restart to become functional. The next time a user logs in it will be active.

Doc source: https://help.duo.com/s/article/1090?language=en_US

Optionally, you can run this command with other switches such as /norestart to prevent any pending restarts the machine may have.

Testing:

  • I had a machine with a previous version of duo, ran the installer and it automatically rebooted it. I reset the scenario and I changed the package to /norestart and this time it didn't reboot after upgrade.

I didn't see a way to make an issue in this repo which is why I opted for a pull request. Thoughts?

DUO installer will forceably restart the local machine if needed. This can be unpredictable. Adding /norestart gives you flexibility to restart at your convenience. Also, from my testing duo does really need a restart to become functional. The next time a user logs in it will be active. 

Doc source: https://help.duo.com/s/article/1090?language=en_US

> Optionally, you can run this command with other switches such as /norestart to prevent any pending restarts the machine may have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant