Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make structures Send #28

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Make structures Send #28

merged 3 commits into from
Feb 17, 2020

Conversation

bltavares
Copy link
Member

Choose one: a 🙋 feature

Using hypercore on a multi-threaded async/await executor requires it to be send, requiring this stream also to be send.

This commit adds an example which requires the crate to be send, and changes all references to Rc with Arc.

Checklist

  • tests pass
  • tests and/or benchmarks are included: async example
  • documentation is changed or added

Context

Semver Changes

Major, as it breaks impls of the trait

Copy link
Collaborator

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@yoshuawuyts yoshuawuyts merged commit 5452a3a into datrs:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants