Refactor load.py to have an agnostic config #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y; generalizing to external wrapper
rufuspollock
approved these changes
Jun 12, 2020
| @@ -31,10 +25,10 @@ def load_csv(data_resource, config={}, connection=None): | |||
|
|
|||
|
|
|||
| def delete_datastore_table(data_resource, config={}): | |||
There was a problem hiding this comment.
For me config is a bad smell - can't we pass arguments explicitly?
| @@ -31,10 +25,10 @@ def load_csv(data_resource, config={}, connection=None): | |||
|
|
|||
|
|
|||
| def delete_datastore_table(data_resource, config={}): | |||
| header = {'Authorization': Variable.get('CKAN_SYSADMIN_API_KEY')} | |||
| header = {'Authorization': config['CKAN_SYSADMIN_API_KEY']} | |||
There was a problem hiding this comment.
Why not pass these arguments explicitly to the function rather than pull from config
There was a problem hiding this comment.
You mean passing several args like load.create_datastore_table(data_resource, Variable.get('CKAN_SYSADMIN_API_KEY'), Variable.get('CKAN_SITE')) ?
|
@hannelita i'm happy either way - i'm not totally clear if we want to go class way vs just have arguments to library functions ... |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to the first task on #10 ; use a continuation on the methods is not ideal yet. We could refactor and create a class wrapping the original library. Can we make it a singleton? In my opinion, it would make sense.
@rufuspollock This refactor suggestion is a matter of cleaning the codebase. Is there time to do so? Work est (to refactor classes and the tests that will break: 2h)