Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate headers from config differently #79

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

tdabasinskas
Copy link
Member

@tdabasinskas tdabasinskas commented Jan 5, 2024

Seems that .String() adds additional quotes on the string it returns. We should use StringValue(), but it's not available on the elements. ElementsAs() should resolve this.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (d270781) to head (5826951).
Report is 161 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   73.67%   74.34%   +0.67%     
==========================================
  Files          11       11              
  Lines        1603     1602       -1     
==========================================
+ Hits         1181     1191      +10     
+ Misses        335      326       -9     
+ Partials       87       85       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Took 8 minutes
@tdabasinskas tdabasinskas self-assigned this Jan 5, 2024
@tdabasinskas tdabasinskas linked an issue Jan 5, 2024 that may be closed by this pull request
@tdabasinskas tdabasinskas merged commit 85cf4ed into main Jan 5, 2024
8 checks passed
@tdabasinskas tdabasinskas deleted the header_quotes branch January 5, 2024 18:39
@tdabasinskas tdabasinskas added the bug Something isn't working label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting custom headers on requests
1 participant